[FFmpeg-devel] [PATCH] lavf/utils: decrease logging level of dump_metadata from INFO to VERBOSE

[Clément Bœsch]

On Fri, Jul 13, 2012 at 11:50:44AM +0200, Stefano Sabatini wrote:
> Decrease log clutter.
> ---
>  libavformat/utils.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/libavformat/utils.c b/libavformat/utils.c
> index f94e5f8..6d17428 100644
> --- a/libavformat/utils.c
> +++ b/libavformat/utils.c
> @@ -3810,7 +3810,7 @@ static void dump_stream_format(AVFormatContext *ic, int i, int index, int is_out
>      if (st->disposition & AV_DISPOSITION_CLEAN_EFFECTS)
>          av_log(NULL, AV_LOG_INFO, " (clean effects)");
>      av_log(NULL, AV_LOG_VERBOSE, "\n");
> -    dump_metadata(NULL, st->metadata, "    ", AV_LOG_INFO);
> +    dump_metadata(NULL, st->metadata, "    ", AV_LOG_VERBOSE);
>  }
>  
>  void av_dump_format(AVFormatContext *ic,
> @@ -3828,7 +3828,7 @@ void av_dump_format(AVFormatContext *ic,
>              index,
>              is_output ? ic->oformat->name : ic->iformat->name,
>              is_output ? "to" : "from", url);
> -    dump_metadata(NULL, ic->metadata, "  ", AV_LOG_INFO);
> +    dump_metadata(NULL, ic->metadata, "  ", AV_LOG_VERBOSE);
>      if (!is_output) {
>          av_log(NULL, AV_LOG_INFO, "  Duration: ");
>          if (ic->duration != AV_NOPTS_VALUE) {
> @@ -3866,7 +3866,7 @@ void av_dump_format(AVFormatContext *ic,
>          av_log(NULL, AV_LOG_INFO, "start %f, ", ch->start * av_q2d(ch->time_base));
>          av_log(NULL, AV_LOG_INFO, "end %f\n",   ch->end   * av_q2d(ch->time_base));
>  
> -        dump_metadata(NULL, ch->metadata, "    ", AV_LOG_INFO);
> +        dump_metadata(NULL, ch->metadata, "    ", AV_LOG_VERBOSE);
>      }
>      if(ic->nb_programs) {
>          int j, k, total = 0;
> @@ -3875,7 +3875,7 @@ void av_dump_format(AVFormatContext *ic,
>                                                    "name", NULL, 0);
>              av_log(NULL, AV_LOG_INFO, "  Program %d %s\n", ic->programs[j]->id,
>                     name ? name->value : "");
> -            dump_metadata(NULL, ic->programs[j]->metadata, "    ", AV_LOG_INFO);
> +            dump_metadata(NULL, ic->programs[j]->metadata, "    ", AV_LOG_VERBOSE);
>              for(k=0; k<ic->programs[j]->nb_stream_indexes; k++) {
>                  dump_stream_format(ic, ic->programs[j]->stream_index[k], index, is_output);
>                  printed[ic->programs[j]->stream_index[k]] = 1;


I'm not sure I like that very much; I often use ffprobe foobar.mp3 to see
these metadata for example.

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120715/1f8ad250/attachment.asc>