[FFmpeg-devel] [PATCH] ffmpeg: fix streamcopy of some mp3 in avi

[Mike Scheutzow]

Michael Niedermayer wrote:
> Fixes Ticket1432
> 
> Thanks-to: Mike Scheutzow <mike.scheutzow at alcatel-lucent.com> for some of the bug analysis
> Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> ---
>  ffmpeg.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ffmpeg.c b/ffmpeg.c
> index c9f2a61..82b9544 100644
> --- a/ffmpeg.c
> +++ b/ffmpeg.c
> @@ -2964,7 +2964,7 @@ static int transcode_init(void)
>                  codec->frame_size         = icodec->frame_size;
>                  codec->audio_service_type = icodec->audio_service_type;
>                  codec->block_align        = icodec->block_align;
> -                if(codec->block_align == 1 && codec->codec_id == CODEC_ID_MP3)
> +                if((codec->block_align == 1 || codec->block_align == 1152) && codec->codec_id == CODEC_ID_MP3)
>                      codec->block_align= 0;
>                  if(codec->codec_id == CODEC_ID_AC3)
>                      codec->block_align= 0;

For the sample file, the timestamps returned by avi_read_packet() for 
stream 1 are complete crap. This is true for ffprobe, ffplay and any 
other app that uses the avi demuxer.

Yet your preferred solution is to hack a special case into a single 
application, and declare the problem fixed?


Mike Scheutzow