[FFmpeg-devel] [PATCH] lavd/oss: support for more than 2 channels

[Nicolas George]

Le tridi 3 thermidor, an CCXX, Paul B Mahol a écrit :
> Yes, I have nor time nor motivation to discuss bikesheding with you
> (or anyone else).

I do not consider it bikesheding. I have lost countless hours because of
software that do channel ordering in an improper way. Problems of that kind
are very annoying to debug because you can not trust anything and you can
rarely isolate a single step. Now that ffmpeg and mplayer do things right
almost everywhere, I would be very annoyed if a patch came ruining that.

For me, the possibilities are those, in descending order:

- implementing things right;
- adding an error message ("multiple channels not supported, patch
  welcome");
- implementing things wrong but with a visible warning;
- nothing at all, leave it to someone who cares and can test;
- implementing things wrong.

So for me, your patch as is is actually making things worse (and I am not
even talking about the fact that you did not even try to make it simpler).
As I already told you twice, you could make your patch acceptable to me by
simply adding a warning; you did not care to comment. I have no power of
preventing you from pushing as is, but if you do I will immediately push an
additional warning.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120720/49031c21/attachment.asc>