[FFmpeg-devel] [PATCH 2/2] lavfi: add concat filter.

[Nicolas George]

Le quartidi 4 thermidor, an CCXX, Stefano Sabatini a écrit :
> @var{n}x...

I find using x for × very ugly, and I like to avoid it whenever possible. In
this particular case, it is a matter of adding $ENCODING="utf-8" in
doc/t2h.init, I'll propose patch for that. There is already another × in the
same file (because of me, I confess).

> n=3

Fixed.

> Bikeshed: # multimedia filters?
> 
> Could be useful to contain filters dealing with more than one media
> type, and thus also transmedia filters. In this case would make sense
> to name the file avf_concat (consistent with the filter private name).

I changed the name of the file. Changing the comment in the Makefile is
unrelated to the patch itself.

> Nit+: some empty lines at the indicated points may help readability.

Added.

> nit: I'd prefer "size %dx%d" or "size:%dx%d" but whatever

Ok.

> I'm not sure I understand this. Shouldn't you fill the audio buffer
> with silence? (a zeroed buffer does not always correspond to silence).

av_samples_alloc(), which is called by the default get_audio_buffer, uses
av_mallocz, and thus valgrind did not complain. Then I forgot about it.
Added av_samples_set_silence().

> I read the rest of the patch and can't spot apparent errors.

I send the last version in a few minutes. I had to add:

inlink->cur_buf = NULL;

in end_frame after the reference was given away because of the changes in
the fork.

I do not know whether I should push immediately or wait until I have a fix
for ffmpeg's scheduling problem (I have it mostly working, but I have a
corner cases to fix).

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120722/b779351c/attachment.asc>