[FFmpeg-devel] [PATCH] zerocodec: fix direct rendering.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Jul 22 22:18:51 CEST 2012


On Sun, Jul 22, 2012 at 03:43:17PM -0400, Derek Buitenhuis wrote:
> On 21/07/2012 3:16 PM, Reimar Döffinger wrote:
> > I guess those failure cases also open other questions:
> > Should the reference frame be freed and cleared on decode failure?
> > Because right now, after a decode failure all the following frames
> > will be silently decoded against a broken reference, which seems
> > at least not ideal.
> 
> Well there's no "right" way. Decode broken frames or none at all.
> I'm impartial so I'll implement whichever people prefer.

I am generally in favour of decoding as well as possible, though to
be honest that would include not failing for a missing reference but
instead using a black reference.
At the same time, we now have decode_error_flags we could use to signal
a (potential) error until the next keyframe while still decoding the
frames.
We might need to discuss how exactly to use it though...


More information about the ffmpeg-devel mailing list