[FFmpeg-devel] [PATCH] tools/bisect-create: Support "bisect run"

Alexander Strasser eclipse7 at gmx.net
Tue Jul 24 01:52:29 CEST 2012


Michael Niedermayer wrote:
> On Mon, Jul 23, 2012 at 12:50:48AM +0200, Alexander Strasser wrote:
> >   Make it possible to use the run bisect sub command. As with all
> > other ffbisect commands, revisions that do not contain the needed
> > tools are skipped.
> 
> LGTM

  Thanks, pushed.

  I noticed now that I probably could have just used '-quoting
to make the "sh -c" shell code argument more readable.

  Additionally getting the list of needed tools could be probably
be done once inside ffbisect wrapper script instead of letting the
shell invoked by "git bisect run" reread the list on every bisection
step.

  Maybe worth to address in a clean-up patch set.

  Alexander


More information about the ffmpeg-devel mailing list