[FFmpeg-devel] ffplay.c Marton Balint - improve desing (without adding features) until looks good

[Lou Logan]

On Tue, 24 Jul 2012 04:50:26 +0200, Juan Manuel Borges Caño wrote:

> First, I decided to use your library in some projects because simply you
> don't have a nearl competitor with this quality.
> http://code.google.com/p/openmedialibrary and
> http://code.google.com/p/openalextensions .
> 
> With that knowledge i have a concern, documentation was lacking everywhere,
> and even not that is enough, ffplay.c could have saved all it, but the code
> is so messily cluttered with features hacked together without desgin
> concerns in mind, that the look was unusable out of a copy/paste and use,
> which could not be because i'm not using the sdl library. If the desgin of
> ffplay.c were made clear it would be a better reference documentation and
> become more plausible to reuse some code and/or learn from it.
> 
> Perhaps you don't get that feeling, but from what i've seen, it is so
> cluttered that makes 10x difficult to follow. Though i know your library is
> very powerful and haves a lot of features.
> 
> To summarize, like talking programming design course, improve the coding
> design of the program and/or even start giving him some love and do an
> ffplay folder so the code starts to split and grow, and even you support
> more backends like opengl/openal yourself, or framebuffer even. If that
> become unusable you would need to almost do that in the docs, so... 2 for 1
> 
> Nice work, don't stop it.

Patch(es) Welcome™

We are all volunteers and time is limited which unfortunately can make
documentation lacking. I assume you are now somewhat familiar with the
code, so perhaps you could contribute. Contributions are appreciated
and if you need any help feel free to ask in #ffmpeg-devel.

Useful stuff:
http://ffmpeg.org/developer.html#Submitting-patches-1
http://git.videolan.org/?p=ffmpeg.git;a=blob;f=doc/git-howto.txt