[FFmpeg-devel] [PATCH] lavc: add channels field to AVFrame

[Michael Niedermayer]

On Mon, Jul 30, 2012 at 07:03:23PM +0200, Stefano Sabatini wrote:
> On date Monday 2012-07-30 18:49:32 +0200, Michael Niedermayer encoded:
> > On Mon, Jul 30, 2012 at 04:11:36PM +0200, Stefano Sabatini wrote:
> > > This is required otherwise it is not always possible to guess the number
> > > of channels from the layout, for example if the channel layout is
> > > unknown.
> > > ---
> > >  libavcodec/avcodec.h |   11 +++++++++++
> > >  libavcodec/utils.c   |    4 ++++
> > >  2 files changed, 15 insertions(+), 0 deletions(-)
> > 
> > LGTM
> > 
> > thanks
> 
> Nit: should be nb_channels (more meaningful, consistent with
> nb_samples) or channels (consistent with AVCodecContext)?

whichever name you prefer ...
i would probably favor consistency to the equivalent field in
other structs like AVCodecContext but thats only a very slight
preferance


> 
> I'm not still sure it is a good idea to propagate the info to lavfi
> (since we may require that the channel layout is always set inside the
> filtergraph), but this patch seems useful on its own and shouldn't
> hurt anyway.

yes, especially when the number changes having it in AVFrame is a good
idea

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120730/571eb8ef/attachment.asc>