[FFmpeg-devel] [PATCH]Do not allow DVCPRO HD encoding, it is broken

[Michael Niedermayer]

On Wed, May 30, 2012 at 10:01:18AM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> Afaict, DVCPRO HD encoding was never supported.
> Related to ticket #1370.
> 
> Please comment, Carl Eugen

>  dv.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 214d08a3d7fcc2b3971419d2c6c6004eae7bdcff  patchdvcprohd.diff
> diff --git a/libavcodec/dv.c b/libavcodec/dv.c
> index cd2cd4b..a430e51 100644
> --- a/libavcodec/dv.c
> +++ b/libavcodec/dv.c
> @@ -335,6 +335,11 @@ static av_cold int dvvideo_init_encoder(AVCodecContext *avctx)
>          ff_dv_print_profiles(avctx, AV_LOG_ERROR);
>          return AVERROR(EINVAL);
>      }
> +    if (avctx->coded_height > 576 ||
> +        !avctx->coded_height && avctx->height > 576) {

i dont think that 2 checks are needed otherwise its probably ok based
on the comments

just please dont forget to remove this check in case someone implements
DVCPRO HD encoding

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120604/596b234c/attachment.asc>