[FFmpeg-devel] [PATCH 1/8] lavf: add internal demuxer helpers for subtitles.

[Nicolas George]

Le primidi 1er messidor, an CCXX, Clément Bœsch a écrit :
> That's not the only reasons: event will always be a null terminated string
> (yes I fixed the doxy-comment), and len is the length, not the size (it
> doesn't count the zero, and is used to avoid some calls to strlen).

Do you actually need that, except for the merge part?

Also, note that currently, the text subtitles packets do not include the
terminating NUL character, while your ff_subtitles_queue_read_packet
includes it.

> > What is the unit of 'start', please?
> Should be in AV_TIME_BASE, unless I'm missing something.

I think it should be in AVStream.time_base. But this API does not need to
know about it, it only uses it to sort and compute the missing duration
fields.

> But they are, in the sense that it only works with strings and they're
> meant to be a full list of "text events" ordered by time (and pos).

I do not see what makes them only work for strings.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120619/627b0820/attachment.asc>