[FFmpeg-devel] [PATCH] riff: don't overwrite bps fromWAVEFORMATEX if EXTENSIBLE doesn't contain that data.

[Don Moir]

> ----- Original Message ----- 
> From: "Hendrik Leppkes" <h.leppkes at gmail.com>
> To: "FFmpeg development discussions and patches" <ffmpeg-devel at ffmpeg.org>
> Sent: Thursday, June 21, 2012 8:19 AM
> Subject: Re: [FFmpeg-devel] [PATCH] riff: don't overwrite bps from 
> WAVEFORMATEX if EXTENSIBLE doesn't contain that data.
>
>
>> On Thu, Jun 21, 2012 at 2:16 PM, Don Moir <donmoir at comcast.net> wrote:
>>
>>> For the above 24 bit avi file, the audio sample_fmt is set to
>>> AV_SAMPLE_FMT_S16 and there is no AV_SAMPLE_FMT_S24.
>>>
>>> So not sure how I am supposed to play that back correctly. If I just 
>>> play
>>> it back now and go with S16 its just static.
>>>
>>
>> Update to latest Git which includes my patch, and it'll be
>> AV_SAMPLE_FMT_S32 with bits_per_coded_sample set to 24, and playback 
>> should
>> work fine. :)
>
> Ok thanks, I was thinking it was probably converted to S32 with your 
> patch.

Not sure if it makes sense to add a new format type of AV_SAMPLE_FMT_S24. 
The justification would be less confusion assuming sample size is 3 bytes 
per channel.