[FFmpeg-devel] [PATCH 2/2] image2: Add "start_number" private option to the demuxer

Mashiat Sarker Shakkhar mashiat.sarker at gmail.com
Sat Jun 23 20:12:30 CEST 2012


On 6/24/2012 12:04 AM, Michael Niedermayer wrote:
> On Sat, Jun 23, 2012 at 10:11:50AM +0600, Mashiat Sarker Shakkhar wrote:
>> Currently if a pattern is given we search for up to the fifth file name in
>> that sequence. This option sets that limit to an arbitrary number.
> [...]
>> @@ -375,6 +376,7 @@ static const AVOption options[] = {
>>       { "video_size",   "", OFFSET(video_size),   AV_OPT_TYPE_STRING, {.str = NULL}, 0, 0, DEC },
>>       { "framerate",    "", OFFSET(framerate),    AV_OPT_TYPE_STRING, {.str = "25"}, 0, 0, DEC },
>>       { "loop",         "", OFFSET(loop),         AV_OPT_TYPE_INT,    {.dbl = 0},    0, 1, DEC },
>> +    { "start_number", "first number in the sequence", OFFSET(start_number), AV_OPT_TYPE_INT, {.dbl = 1}, 1, INT_MAX, DEC },
>>       { NULL },
>
> I think this should be called max_start_number
>
> otherwise the patch LGTM

I can do that, but then the symmetry between muxer and demuxer will be 
lost. Do you insist on this change?

Shakkhar


More information about the ffmpeg-devel mailing list