[FFmpeg-devel] [PATCH 1/4] lavfi: add flush callback.

[Michael Niedermayer]

On Fri, Jun 29, 2012 at 07:15:45PM +0200, Nicolas George wrote:
> Le duodi 12 messidor, an CCXX, Michael Niedermayer a écrit :
> > Hmm, i see the problem, iam not sure i like the solution ...
> 
> I can understand. Here are the other solutions I considered:
> 
> - Pass NULL to start_frame/filter_samples on sinks to mark EOF just like
>   that flush callback, all sinks having to be ready for it. IMHO strictly
>   worse on all accounts.
> 
> - Same as above, but using a flag in rej_perms. Very inelegant.
> 
> - Not support sinks (that need flushing) in ffmpeg (command line tool), only
>   buffersink. All sinks have to pretend they are actually filters, just like
>   (a)showinfo, and produce some output (possibly unchanged).
> 
> - Add a callback to the filter context itself used to order sinks to take
>   some exercise (i.e. request a frame on their input).
> 
> Of course, there may be completely different options I did not think of.

I was thinking of giving sinks a output pad and use its request_frame
instead if the request_frames from the sinks inputs.

but maybe this would not work out cleanly ....

do not count this as objection to your patch ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have often repented speaking, but never of holding my tongue.
-- Xenocrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120629/080fd7cd/attachment.asc>