[FFmpeg-devel] [PATCH 2/2] fate: add a test for the -force_key_frames option.

[Michael Niedermayer]

On Sat, Jun 30, 2012 at 12:31:54PM +0200, Nicolas George wrote:
> It broke twice in the last three months due to other changes.
> 
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  tests/Makefile                          |    1 +
>  tests/fate/options.mak                  |    9 +++++++++
>  tests/ref/fate/options-force_key_frames |    4 ++++
>  3 files changed, 14 insertions(+)
>  create mode 100644 tests/fate/options.mak
>  create mode 100644 tests/ref/fate/options-force_key_frames
> 
> diff --git a/tests/Makefile b/tests/Makefile
> index 266901c..eda938a 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -65,6 +65,7 @@ include $(SRC_PATH)/tests/fate/lossless-video.mak
>  include $(SRC_PATH)/tests/fate/microsoft.mak
>  include $(SRC_PATH)/tests/fate/mp3.mak
>  include $(SRC_PATH)/tests/fate/mpc.mak
> +include $(SRC_PATH)/tests/fate/options.mak
>  include $(SRC_PATH)/tests/fate/pcm.mak
>  include $(SRC_PATH)/tests/fate/probe.mak
>  include $(SRC_PATH)/tests/fate/prores.mak
> diff --git a/tests/fate/options.mak b/tests/fate/options.mak
> new file mode 100644
> index 0000000..940d454
> --- /dev/null
> +++ b/tests/fate/options.mak
> @@ -0,0 +1,9 @@
> +FATE_OPTIONS += fate-options-force_key_frames
> +fate-options-force_key_frames: tests/data/vsynth2.yuv
> +fate-options-force_key_frames: CMD = enc_dec \
> +  "rawvideo -s 352x288 -pix_fmt yuv420p" tests/data/vsynth2.yuv \
> +  avi "-c mpeg4 -g 240 -qscale 10 -force_key_frames 0.5,0:00:01.5" \
> +  framecrc "" "" "-skip_frame nokey"
> +
> +FATE_FFMPEG += $(FATE_OPTIONS)
> +fate-options: $(FATE_OPTIONS)
> diff --git a/tests/ref/fate/options-force_key_frames b/tests/ref/fate/options-force_key_frames
> new file mode 100644
> index 0000000..205296c
> --- /dev/null
> +++ b/tests/ref/fate/options-force_key_frames
> @@ -0,0 +1,4 @@
> +654970e7a09ff4869596c2a47e698007 *tests/data/fate/options-force_key_frames.avi
> +113320 tests/data/fate/options-force_key_frames.avi
> +8f68ad2e602ecd87a3e0c097ba99d773 *tests/data/fate/options-force_key_frames.out.framecrc

> +stddev:34363.01 PSNR:  5.61 MAXDIFF:56305 bytes:  7603200/      186

this looks like 2 unrelated files are compared, is this intended ?


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120630/a8c3e73b/attachment.asc>