[FFmpeg-devel] [libav-devel] [PATCH] movie source add repeat count parameter

[Michael Niedermayer]

On Thu, Mar 15, 2012 at 02:40:46PM +0800, William Yu wrote:
> 在 2012年3月1日 下午9:20，William Yu <genwillyu at gmail.com> 写道：
> > 在 2012年2月29日 下午8:19，Stefano Sabatini <stefasab at gmail.com> 写道：
> >> On date Tuesday 2012-02-28 19:02:35 +0800, William Yu encoded:
> >>> I think movie source can add a repeat count for read source several times.
> >>> When repeat count is zero, then repeat again and again.
> >>> repeat count parameter has an alias "rc"
> > ...
> >>
> >> Also I see a synch problem here, when you repeat the source, the
> >> timestamp is reset to the original time, while we should probably have a
> >> timestamp_offset and add that to the movie timestamp in the subsequent
> >> plays, so that we have a monotonically increasing timestamp sequence.
> >
> > I think movie source should keep original time, let next filter to determine
> > how to use these frame. if next filter need monotonically increasing timestamp,
> > it can insert setpts filter or other filters to fix timestamp. In the
> > movie source,
> > when rewind,   we are difficult to determine first frame's timestamp.
> >
> > others are updated. Please check again.
> >>
> >> Also did you test with image files?
> >>
> >> Thanks.
> >> _______________________________________________
> 
> This patch has other problems? Or It is unuseful? I think when you want to apply
> animation logo to whole movie, you need this patch.

sorry for the delay
the patch is certainly usefull.

the patch seems to mix tabs and spaces for indent (tabs arent allowed
in ffmpeg), see tools/patcheck in ffmpeg git, it will list where tabs
are

also please use
git format-patch or send-email
that way the patch contains a commit message and can simply be applied
with git am.

Thanks

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

What does censorship reveal? It reveals fear. -- Julian Assange
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120315/2d380880/attachment.asc>