[FFmpeg-devel] [PATCH] vsrc_color: port to new drawutils API.

[Stefano Sabatini]

On date Sunday 2012-03-18 09:34:18 +0100, Nicolas George encoded:
> Le nonidi 29 ventôse, an CCXX, Stefano Sabatini a écrit :
> > Patch looks cool, but I noticed that the single memcpy in
> > ff_draw_rectangle() (which was using the pre-filled buffer) was
> > replaced by a loop on the width in ff_fill_rectangle(), I wonder if this
> > impacts on performance (I remember when I first implemented
> > ff_draw_rectangle() it did).
> 
> You may notice that the loop on the width is only for the first line of the
> rectangle: all the other lines are copied from the first one. Thus, any
> difference would only be visible for rectangles with a large width and a
> small height.
> 
> I ran a benchmark for vf_pad, and I did not notice any significant
> difference, even for the horizontal border slice.

Sounds fine then.
-- 
FFmpeg = Faithless and Fascinating Mythic Power Efficient Gem