[FFmpeg-devel] [PATCH] Change default behaviour of scale filter from 'progressive' to 'auto'

[Tim Nicholson]

On 30/03/12 16:47, Tim Nicholson wrote:
> On 30/03/12 15:47, Michael Niedermayer wrote:
>> On Fri, Mar 30, 2012 at 10:51:28AM +0100, Tim Nicholson wrote:
>>> When the option of interlaced aware scaling was first introduced interlace detection
>>> was poor. This has been improved, and this proposed patch changes the default behaviour
>>> of the filter to depend upon the auto detected value, bringing it into line with
>>> many other options whose default value is -1 (auto).
>>>
>>> From 4d1ad96e209b18bdf86530d153a6a5acbc5aab8a Mon Sep 17 00:00:00 2001
>>> From: Tim Nicholson <Tim.Nicholson at bbc.co.uk>
>>> Date: Fri, 30 Mar 2012 10:43:46 +0100
>>> Subject: [PATCH] Make default setting of parameter interl=-1 (auto)
>>>
>>> Previously default was 0 (progressive), but interlace detection has been
>>> improved in 648e55ff, and this makes the behaviour consistent with other
>>> options that use 1|0|-1 with -1 the default.
>>
>> This patch changes several fate tests checksums
>>
>> please check if these changes are ok and if so update the checksums
>> with the patch
>>
> 
> Hmmm. I didn't think a command line selection logic change would affect
> fate. But I am beginning to think that this change may be affecting auto
> inserted filters (hopefully for the better if it stops them mangling
> interlaced material).
> 
> I'm not very fluent with fate, so this may take a while....
> 
> 
>>
>> [...]
>> Test vsynth1-dnxhd_1080i failed. Look at tests/data/fate/vsynth1-dnxhd_1080i.err for details.
>> make: *** [fate-vsynth1-dnxhd_1080i] Error 1

OK so I have looked at "tests/data/fate/vsynth1-dnxhd_1080i.err" and it
seems to be a normal console output for 2 passes of ffmpeg:-

pgmyuv -> dnxhd

then

dnxhd -> rawvideo


What am I looking for? How do I check/update the checksums?

>> [..]
>> Test vsynth1-dv failed. Look at tests/data/fate/vsynth1-dv.err for details.
>> make: *** [fate-vsynth1-dv] Error 1
>>
>> [...]
> 
> 


-- 
Tim