[FFmpeg-devel] [PATCH 17/17] lavu/error: fix make checkheaders.

Clément Bœsch ubitux at gmail.com
Wed May 9 13:18:56 CEST 2012


On Wed, May 09, 2012 at 12:43:56PM +0200, Michael Niedermayer wrote:
> On Wed, May 09, 2012 at 10:01:42AM +0200, Clément Bœsch wrote:
> > From: Clément Bœsch <clement.boesch at smartjog.com>
> > 
> > The errors need to be defined before including functions depending on
> > them. See av_size_mult() for instance.
> > ---
> >  libavutil/error.h |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/libavutil/error.h b/libavutil/error.h
> > index 3b05e4b..6a7eec6 100644
> > --- a/libavutil/error.h
> > +++ b/libavutil/error.h
> > @@ -25,7 +25,6 @@
> >  #define AVUTIL_ERROR_H
> >  
> >  #include <errno.h>
> > -#include "avutil.h"
> 
> probably should be include stddef.h or so
> 

I included unistd.h at first (for the size_t in the prototype below), but
it conflicted with too much internal symbols (like sync() or close())
so I thought it wasn't that a good idea.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120509/947d5f90/attachment.asc>


More information about the ffmpeg-devel mailing list