[FFmpeg-devel] [PATCH] Optimization of AMR NB and WB decoders for MIPS

[Carl Eugen Hoyos]

Babic, Nedeljko <nbabic <at> mips.com> writes:

> > If you do such unrolling, please say in the documentation of the
> > function (in acelp_filter.h) that n should be a multiple of eight or
> > any other thing that it requires. Also, please note that this code is
> > not only used for AMR, but also for other vocoders. Can you check if
> > the other uses respect the multiple-of-eight constraint?
>
> We checked if unrolling can be done (regarding multiple-of-eight 
> constraint) in all the places where this function is called. The 
> same goes for all the function where we done loop unrolling.
> Comment will be put in documentation of the function. Should I 
> specify that the comment is just for MIPS optimizations?

If you tested that qcelp, sipr and wmavoice still work with this
assumption, imo, you don't have to limit the need on MIPS
(although an explanation is probably useful).

Carl Eugen