[FFmpeg-devel] [PATCH]Recognize "qt " compatible brand in isom

[Michael Niedermayer]

On Fri, Nov 02, 2012 at 03:50:29PM +0100, Clément Bœsch wrote:
> On Fri, Nov 02, 2012 at 03:37:32PM +0100, Carl Eugen Hoyos wrote:
> > Hi!
> > 
> > Attached patch fixes ticket #1881 for me, I don't know if it has funny 
> > side-effects.
> > 
> > Please review, Carl Eugen
> 
> > diff --git a/libavformat/mov.c b/libavformat/mov.c
> > index d7d7f21..3488a80 100644
> > --- a/libavformat/mov.c
> > +++ b/libavformat/mov.c
> > @@ -755,6 +755,8 @@ static int mov_read_ftyp(MOVContext *c, AVIOContext *pb, MOVAtom atom)
> >      avio_read(pb, comp_brands_str, comp_brand_size);
> >      comp_brands_str[comp_brand_size] = 0;
> >      av_dict_set(&c->fc->metadata, "compatible_brands", comp_brands_str, 0);
> > +    if (!strncmp(comp_brands_str, "qt  ", 4))
> > +        c->isom = 0;
> 
> You can have several compatible brands, why would you compare to only one?
> 
> Also, I'm not sure that's a good idea to have a compatible brand with QT
> having such "huge" consequence…

maybe we should rename isom to qt and flip the value ?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121102/7d32e7a4/attachment.asc>