[FFmpeg-devel] [PATCH 4/4] cmdutils: allow to set the report file name.

[Stefano Sabatini]

On date Saturday 2012-11-03 17:12:07 +0100, Nicolas George encoded:
> Le tridi 13 brumaire, an CCXXI, Stefano Sabatini a écrit :
> > I'm not really sure about this, having
> > FFREPORT=file=funky-filename-template
> > 
> > looks more extensible, but I don't know if we'll need to add more
> > options.
> 
> What exactly are you not sure about? One of the concerns when writing this
> is that some people probably already use the FFREPORT environment variable,
> as it is currently used: setting it to anything enables the report. We would
> not want people who have set FFREPORT=1 to get all their reports in a file
> called "1". And I think using several environment variables is annoying.
> There is IMHO a very low probability of someone having set their FFREPORT
> environment variable to anything starting with "file=" by coincidence.

Uhm I see, the alternative would be FFREPORT_FILENAME, which could
deprecate FFREPORT (and thus force the user to set the template).

> 
> >	   Also if you want to really support
> > FFREPORT=key1=val1:key2=val2... then the usual considerations on
> > escaping should be applied (think about C:\Windows\file), which
> > complicates the interface for the user.
> 
> I have not actually tested, but since it is handled using the very same
> functions as the options parsing algorithm, it should already be taken care
> of.
> 
> If the above satisfies you, I will push this soon.

The only problem is that the user will have to do:
FFREPORT="file='C:\Windows\file'"

or something like that for escaping the special character ':', maybe
mention that in the docs (something like: "The @code{:} character is
special and needs to be escaped).

Note that I have no strong position about FFREPORT_FILENAME or this
one, so I'll let you judge what is better.
-- 
FFmpeg = Fostering and Fabulous Martial Phony Ecumenical Geek