[FFmpeg-devel] [PATCH] lavu/opt: show valid range in case of out-of-range value

[Nicolas George]

Le quartidi 14 brumaire, an CCXXI, Stefano Sabatini a écrit :
> Improve feedback.

Good idea.

> ---
>  libavutil/opt.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavutil/opt.c b/libavutil/opt.c
> index ab95d04..3122e74 100644
> --- a/libavutil/opt.c
> +++ b/libavutil/opt.c
> @@ -88,8 +88,8 @@ static int read_number(const AVOption *o, void *dst, double *num, int *den, int6
>  static int write_number(void *obj, const AVOption *o, void *dst, double num, int den, int64_t intnum)
>  {
>      if (o->max*den < num*intnum || o->min*den > num*intnum) {
> -        av_log(obj, AV_LOG_ERROR, "Value %f for parameter '%s' out of range\n",
> -               num*intnum/den, o->name);
> +        av_log(obj, AV_LOG_ERROR, "Value %f for parameter '%s' out of range [%f - %f]\n",
> +               num*intnum/den, o->name, o->min, o->max);

Does %g not provide a more readable output in the general case?

>          return AVERROR(ERANGE);
>      }

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121104/f6c72ee5/attachment.asc>