[FFmpeg-devel] [PATCH] fate-rsync: replace -a by -rlt

[Michael Niedermayer]

On Tue, Nov 06, 2012 at 04:05:53PM +0100, Jean First wrote:
> On Tue Nov 06 2012 14:48:25 GMT+0100 (CET), Michael Niedermayer wrote:
> >This remove the owner, group and permission preservation on fatesample checkouts
> >These caused problems for durandal_1707
> >
> >Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> >---
> >  tests/Makefile |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/tests/Makefile b/tests/Makefile
> >index 06a5aa7..da7fdc1 100644
> >--- a/tests/Makefile
> >+++ b/tests/Makefile
> >@@ -134,7 +134,7 @@ ifdef SAMPLES
> >  FATE += $(FATE_FULL) $(FATE_FULL-yes)
> >  FATE += $(FATE_EXTERN)
> >  fate-rsync:
> >-	rsync -vaLW --timeout=60 --contimeout=60 rsync://fate-suite.ffmpeg.org/fate-suite/ $(SAMPLES)
> >+	rsync -vrltLW --timeout=60 --contimeout=60 rsync://fate-suite.ffmpeg.org/fate-suite/ $(SAMPLES)
> >  else
> >  fate::
> >  	@echo "warning: only a subset of the fate tests will be run because SAMPLES is not specified"
> 
> Not related to this patch but it reminds me: osx rsync has no
> --contimeout option. maybe we could remove it too. see http://developer.apple.com/library/mac/#documentation/Darwin/Reference/ManPages/man1/rsync.1.html

the timeout options are important so that fate clients dont get
stuck when there are connection problems, which at least for me
tends to happen too often

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121106/5e7e6bfd/attachment.asc>