[FFmpeg-devel] [PATCH 1/7] lavfi/tile: allow named arguments.

[Alexander Strasser]

Clément Bœsch wrote:
> On Sat, Nov 10, 2012 at 01:51:29AM +0100, Alexander Strasser wrote:
> > Hi Clément,
> > 
> > Clément Bœsch wrote:
> > [...]
> > > +
> > > +static const AVOption tile_options[] = {
> > > +    { "size", "set tile size", OFFSET(w), AV_OPT_TYPE_IMAGE_SIZE, {.str = "6x5"}, 0, 0, FLAGS },
> > > +    { "s",    "set tile size", OFFSET(w), AV_OPT_TYPE_IMAGE_SIZE, {.str = "6x5"}, 0, 0, FLAGS },
> > 
> >   The name "size" and the description seem misleading to me.
> > 
> 
> I kind of agree…
> 
> >   Suggestion:
> >   tiles, set layout of tiles
> > 
> 
> …but this doesn't really sound better to me. Unless someone else complains
> I'd like to keep "size" against "tiles". Maybe another suggestion would
> change my mind.

  Maybe just "layout" or "grid"?

  If we cannot agree on anything besides "size" then you could at least
change the description, like I suggested above, so it doesn't read like
it is the size of the tile that gets set.

Sorry for the name wars...
  Alexander

P.S.
What's in a name? I don't know, but I do know it can make a big difference.