[FFmpeg-devel] [PATCH 3/3] lavfi/drawtext: implement more generic expansion.

[Nicolas George]

Le decadi 20 brumaire, an CCXXI, Clément Bœsch a écrit :
> Use /the/ old /strftime/-style...

Fixed.

> expansion

Ditto.

> Note: make sure that documentation renders well in the HTML and manpage
> output, these special characters are known for causing troubles in the
> output.

It was ok, but it made me notice another problem, addressed in a separate
trivial patch.

> functions

Fixed.

> Sounds nice. Do you plan to do as well for the SMPTE Timecode and the

All I know about SMPTE timecodes is that they seems a pretty braindead
design and I do not want to touch them with a very long stick. I would not
know how to test anyway. I was counting on you to port them to the new
expansion API :) With the infrastructure in place, it should be pretty easy.

> filters metadata? :)

This one, sure, as soon as we have useful test cases (do we already?): that
was my main motivation to start working on it.

> I'd rather call this "end" since it's reached in case of success as well.

Changed.

Also, changed ${...} into %{...}: it will make quoting easier ($ must be
quoted for the shell even in double quotes, not %), and even more so if we
implement environment variables expansion in av_get_token().

New patch sent, thanks for the review.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121111/eb4b45db/attachment.asc>