[FFmpeg-devel] [PATCH 1/7] lavfi/tile: allow named arguments.

[Clément Bœsch]

On Sun, Nov 11, 2012 at 01:26:53AM +0100, Alexander Strasser wrote:
> Clément Bœsch wrote:
> > On Sat, Nov 10, 2012 at 10:46:43PM +0100, Nicolas George wrote:
> > > Le decadi 20 brumaire, an CCXXI, Alexander Strasser a écrit :
> > > >   Maybe just "layout" or "grid"?
> > > 
> > > I think layout sounds good.
> > > 
> > 
> > OK for "layout" (even though I actually prefer "grid", but let's not
> > bikeshed too much). Should I add a short 1-letter name?
> > 
> > > It may be worth to advertise the short syntax more, so that the name is more
> > > rarely used anyway. But I can not suggest a good way of expressing it :(
> > > 
> > 
> > In my documentation example, I put that first grid size argument unnamed
> > followed by named parameters; I think it's a good trade off between the
> > two.
> 
>   Ack. I liked that example you added.
> 
>   IMHO it is one of the cases where the mix of positioned and named options
> really is superior to the pure forms.
> 

Great. Patchset applied, hopefully taking into account everyone's opinion.

Thanks Nicolas & Alexander for the review

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121111/7b3ffa0e/attachment.asc>