[FFmpeg-devel] [PATCH 2/5] pp: add pp_get_context2().

[Michael Niedermayer]

On Sun, Nov 18, 2012 at 04:23:17PM +0100, Clément Bœsch wrote:
> On Sun, Nov 18, 2012 at 01:06:29AM +0100, Michael Niedermayer wrote:
> > On Sun, Nov 18, 2012 at 12:34:33AM +0100, Clément Bœsch wrote:
> > > On Sun, Nov 18, 2012 at 12:24:45AM +0100, Michael Niedermayer wrote:
> > > [...]
> > > > > > Is this neccessary ?
> > > > > > wouldnt simply adding a PP_CPU_CAPS_AUTO achive nearly the same ?
> > > > > > 
> > > > > 
> > > > > Sure, but I thought it would be better to get rid at some point of the
> > > > > duplicated flags and pixel formats; that's the main reason of that patch,
> > > > > we can remove all the PP macro and allow a better integration with FFmpeg.
> > > > > 
> > > > > This will also allow a native vf pp to not bother anymore about a pixel
> > > > > formats mapping.
> > > > > 
> > > > > New attached patch clarifies how it would look at next major bump.
> > > > [...]
> > > > 
> > > > > --- a/libpostproc/postprocess.h
> > > > > +++ b/libpostproc/postprocess.h
> > > > > @@ -77,9 +77,11 @@ void  pp_postprocess(const uint8_t * src[3], const int srcStride[3],
> > > > >  pp_mode *pp_get_mode_by_name_and_quality(const char *name, int quality);
> > > > >  void pp_free_mode(pp_mode *mode);
> > > > >  
> > > > > -pp_context *pp_get_context(int width, int height, int flags);
> > > > > +pp_context *pp_get_context2(int width, int height, int pixfmt);
> > > > 
> > > > before this there are general purpose flags allowing future extension
> > > > after this they are not there anymore.
> > > > I dont know if we will ever need such flags but it doesnt seem
> > > > a good idea to me to drop them
> > > > 
> > > 
> > > If that occurs, won't we instead choose to use AVOptions/av_class (like
> > > every other libs of the projects), which should allow such flexibility? We
> > > should be able to add this without major bumps.
> > 
> > Currently there are many projects using pp_get_context()
> > If we would drop pp_get_context() every of them would need to be
> > updated.
> > If later we require yet another API to access some flags that again
> > would reuquire every of these applications to be updated (if they
> > want to use the flags or we drop pp_get_context2())
> > also if they want to support older libpostproc prior to these
> > changes it will get even harder for them
> > 
> > Thus i think droping either flags or pp_get_context() is not a good
> > idea. 
> > 
> 
> OK, as you prefer. New patch attached, along with a replacement for the
> 3rd patch.

LGTM,

thanks!

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121118/376da441/attachment.asc>