[FFmpeg-devel] [PATCH] lavf: JSON captions demuxer.

[Nicolas George]

Le quintidi 5 messidor, an CCXX, Clément Bœsch a écrit :
> You really don't like typedef struct aren't you? :-)
> 
> I can blame you, though we try keep some consistency…

Ok for consistency.

> nit: I used 'q' in the other demuxers, but maybe you don't like it as
> well… :-)

This one is way too short to be readable when there are several fields in
the structure.

>						 Can you provide a random
> sample & test for fate (covering UTF-8 stuff would be nice)?

I will work on the FATE test once the demuxer is applied.

> BTW, did you see if that format is use somewhere else than TED? If not,
> maybe it would be wise to name it differently. Or maybe there are some
> public specs somewhere?

It seems completely TED-specific. Would people prefer adding "ted" in the
name? "tedjsoncaptions"? "tedcaptions"?

> Also, I suppose the start_time is to skip TED opening?

Yes, I added an explanation in the doc.

> Last thing: all the languages are in different files, right (so you don't
> have a format with multiple possible streams)?

Yes.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121118/4176e675/attachment.asc>