[FFmpeg-devel] [PATCH] AST muxer

Paul B Mahol onemda at gmail.com
Thu Nov 22 20:07:31 CET 2012


On 11/22/12, jamal <jamrial at gmail.com> wrote:
> On 22/11/12 3:24 PM, Paul B Mahol wrote:
>>> No, i don't. I only tested it with PCM_S16B_PLANAR, which works fine.
>>> If we can't be sure it will work with ADPCM AFC then I can disable the
>>> corresponding code for now (Maybe returning AVERROR_PATCHWELCOME while
>>> at
>>> it).
>>
>> Testing on Wii should be even better.
>>
>> There is no need to disable code if it is correctly implemented.
>
> In theory it is. There doesn't seem to be any difference in how
> pcm_s16b_planar and adpmc afc streams are stored inside the ast file.
> Even your demuxer treats them the same way.

Not really. APC sample just add extra 32 bytes of padding for whatever stupid
reason to last frame. Your muxer do not need to do this.
>
> And unfortunately i can't test on a Wii since i don't have one.
> However, the files i created with this muxer worked with every demuxer i
> tried.

Isn't there only one?


More information about the ffmpeg-devel mailing list