[FFmpeg-devel] [PATCH] lavu/opt: add av_opt_ accessors for pixel/format/image size options

[Stefano Sabatini]

On date Saturday 2012-11-24 08:45:00 +0000, Paul B Mahol encoded:
> On 11/23/12, Stefano Sabatini <stefasab at gmail.com> wrote:
> > On date Sunday 2012-11-11 15:14:32 +0100, Stefano Sabatini encoded:
> >> On date Wednesday 2012-11-07 23:58:07 +0100, Stefano Sabatini encoded:
> >> > On date Tuesday 2012-11-06 13:31:53 +0100, Michael Niedermayer encoded:
> >> > > On Tue, Nov 06, 2012 at 01:09:38AM +0100, Stefano Sabatini wrote:
> >> [...]
> >> > > Iam not sure a public function pair for each type added is a good
> >> > > idea.
> >> >
> >> > This is basically following what is already done in the defied
> >> > interface.
> >> >
> >> > > But if we go this route, at least the code should check the types,
> >> > > i would not want to have a flags or pixel format read as
> >> > > AVSampleFormat without warning
> >> >
> >> > Fixed.
> >>
> >> Possible advantages of this approach: safer setting of options, more
> >> sensical feedback. Cons: bloat.
> >>
> >> Ping (see also attached patch to see a possible application).
> >> --
> >> FFmpeg = Fundamental Foolish Merciful Plastic Exploitable Game
> >
> >> From b552f4dfceb89688c384f0fdc57cce0077175578 Mon Sep 17 00:00:00 2001
> >> From: Stefano Sabatini <stefasab at gmail.com>
> >> Date: Sun, 4 Nov 2012 15:32:56 +0100
> >> Subject: [PATCH] lavu/opt: add av_opt_ accessors for pixel/format/image
> >> size
> >>  options
> >>
> >> The interface is implemented against the style of the other options
> >> accessors. Possibly simplify programmatic setting of options.
> >>
> >> TODO: bump minor, update Changelog
> >> ---
> >>  libavutil/opt.c |  112
> >> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >>  libavutil/opt.h |    8 ++++
> >>  2 files changed, 120 insertions(+)
> >
> > Ping.
> 
> lgtm

Updated with some simplifications and message tweaking.
Michael?
-- 
FFmpeg = Foolish & Fundamental Mere Practical Erotic Gladiator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavu-opt-add-av_opt_-accessors-for-pixel-format-imag.patch
Type: text/x-diff
Size: 6550 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121125/7205eb99/attachment.bin>