[FFmpeg-devel] [PATCH] lavfi/drawtext: add support to expansion of generic expressions

[Stefano Sabatini]

On date Tuesday 2012-11-27 20:42:45 +0100, Nicolas George encoded:
> Le septidi 7 frimaire, an CCXXI, Stefano Sabatini a écrit :
> > This is a post-configuration error, so can't be detected during
> > configuration, and I felt a bit uneasy about aborting after that
> > stage.
> 
> Other kind of errors, such a spelling mistake in the function name, have
> that kind of effect, so there is not much scruple to have.
> 
> >	 Also note that the function *is* returning an error,
> 
> Indeed, my bad.
> 
> >							      but it is
> > ignored by the higher-level function.
> 
> True. This should probably be fixed, but it is unrelated.
> 
> For now, I would just suggest to replace AV_LOG_WARNING by AV_LOG_ERROR and
> to drop the expr_func_warning_done bit, because having that kind of
> safeguard for that particular error and not all the similar errors that can
> happen looks rather silly.
> 
> Apart from that, I think you can go ahead and push.

Thanks for the review, pushed.
-- 
FFmpeg = Fabulous and Fascinating Multimedia Programmable Elastic Goblin