[FFmpeg-devel] [PATCH] mingw: Use avprive_vsnprintf in bprint

jamal jamrial at gmail.com
Fri Sep 21 23:54:35 CEST 2012


On 21/09/12 5:20 PM, Derek Buitenhuis wrote:
> I just remembered that force including a local header may break configure checks (as it
> cannot find dir/name.h). It should work if we pass it an absolute path though.
> 
> We could also just make one header and force include it in both MSVC and MinGW, but
> the wrapper would have to be updated to have '-FI <path>' (as opposed to '-FI<path>').

Better leave the MSVC stuff as is. It doesn't need a header and it's better like that.

GCC uses -include and not -FI, and one way to get around the problem with configure checks is by adding the add_cflags line near the end of the file. For example, inside the "enabled gcc" check at line 3883. It would be the last check made before things get dumped to config.mak/h.
Alternatively there's also the force_include() function Bultje wrote a few weeks ago.

Why is that some people don't like the idea of a header that gets included only in the files that need this, anyway? For vnsprintf it would be nine files, and there's no need to do it for snprintf since MSVC can use -D instead of function prototypes.
Globally forcing the inclusion of a header from the command line is really ugly.


More information about the ffmpeg-devel mailing list