[FFmpeg-devel] [PATCH] Document why we always send a Range HTTP header.

[Michael Niedermayer]

On Sun, Sep 23, 2012 at 03:27:20PM +0200, Reimar Döffinger wrote:
> Signed-off-by: Reimar Döffinger <Reimar.Doeffinger at gmx.de>
> ---
>  libavformat/http.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/libavformat/http.c b/libavformat/http.c
> index 376ff9e..e3bfbc4 100644
> --- a/libavformat/http.c
> +++ b/libavformat/http.c
> @@ -411,6 +411,9 @@ static int http_connect(URLContext *h, const char *path, const char *local_path,
>      if (!has_header(s->headers, "\r\nAccept: "))
>          len += av_strlcpy(headers + len, "Accept: */*\r\n",
>                            sizeof(headers) - len);
> +    // Note: we send this on purpose even when s->off is 0,
> +    // since it allows us to detect more reliably if a (non-conforming)
> +    // server supports seeking by analysing the reply headers.
>      if (!has_header(s->headers, "\r\nRange: ") && !post)
>          len += av_strlcatf(headers + len, sizeof(headers) - len,
>                             "Range: bytes=%"PRId64"-\r\n", s->off);

LGTM

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120923/166a2a8f/attachment.asc>