[FFmpeg-devel] [PATCH]Support more AVC-Intra files

Michael Niedermayer michaelni at gmx.at
Wed Sep 26 14:28:35 CEST 2012


On Wed, Sep 26, 2012 at 12:13:53PM +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> Followup to http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/151321
> Attached patch by Reimar and Thomas Mundt fixes some AVC-Intra files from 
> different tickets.

> It does not fix http://samples.ffmpeg.org/ffmpeg-
> bugs/trac/ticket524/AVCI50.mov

which file does it fix ?


[...]

> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> index 16b8c12..1aff75b 100644
> --- a/libavformat/mxfdec.c
> +++ b/libavformat/mxfdec.c

mixing mxfdec and movdec changes in the same patch is bad


> @@ -1484,10 +1484,6 @@ static int mxf_parse_structural_metadata(MXFContext *mxf)
>          /* TODO: drop PictureEssenceCoding and SoundEssenceCompression, only check EssenceContainer */
>          codec_ul = mxf_get_codec_ul(ff_mxf_codec_uls, &descriptor->essence_codec_ul);
>          st->codec->codec_id = codec_ul->id;
> -        if (descriptor->extradata) {
> -            st->codec->extradata = descriptor->extradata;
> -            st->codec->extradata_size = descriptor->extradata_size;
> -        }
>          if (st->codec->codec_type == AVMEDIA_TYPE_VIDEO) {
>              source_track->intra_only = mxf_is_intra_only(descriptor);
>              container_ul = mxf_get_codec_ul(mxf_picture_essence_container_uls, essence_container_ul);

> @@ -1501,6 +1497,7 @@ static int mxf_parse_structural_metadata(MXFContext *mxf)
>                      av_log(mxf->fc, AV_LOG_INFO, "SegmentedFrame layout isn't currently supported\n");
>                      break;
>                  case FullFrame:
> +                    st->codec->field_order = AV_FIELD_PROGRESSIVE;
>                      break;
>                  case OneField:
>                      /* Every other line is stored and needs to be duplicated. */

this looks unrelated
but iam not mxfdec maintainer ...

rest (outside mxfdec) LGTM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120926/c368807e/attachment.asc>


More information about the ffmpeg-devel mailing list