[FFmpeg-devel] [PATCH 2/2] lavfi/sink_buffer: implement libav compatibility API.

[Pavel Koshevoy]

On 9/27/2012 8:51 AM, Nicolas George wrote:
> Le quintidi 5 vendémiaire, an CCXXI, Michael Niedermayer a écrit :
>> for me it seems crashing at fate-flic-magiccarpet, which it does not
>> do with incompatible_fork_abi
>>
>> but the patch should be ok as i didnt notice a change when
>> incompatible_fork_abi is enabled
>>
>> Program received signal SIGSEGV, Segmentation fault.
>> 0x00007ffff795e41f in vsink_init (ctx=0x63fb20, args=0x0, opaque=0x110) at libavfilter/sink_buffer.c:207
> That is very strange, and it does not happen for me:
>
>
> avconv_filter.c:
>
>      ret = avfilter_graph_create_filter(&ofilter->filter,
>                                         avfilter_get_by_name("buffersink"),
>                                         name, NULL, NULL, fg->graph);

I've seen this crash, and the problem was in my code. 
avfilter_graph_create_filter used to work fine to init vsink filter if 
you passed it a pixel formats array via the opaque pointer.  Now it 
seems necessary to pass in a pointer to AVBufferSinkParams which 
contains the pixel formats array pointer.  Anyway, that's what fixed it 
for me.

https://sourceforge.net/p/apprenticevideo/code/404/

Hope this helps,
     Pavel