[FFmpeg-devel] [PATCH 1/2] libavutil/libavfilter: opencl wrapper based on comments on 20130401

[Stefano Sabatini]

On date Monday 2013-04-01 20:15:33 +0800, Wei Gao encoded:
> 2013/4/1 Stefano Sabatini <stefasab at gmail.com>
> 
> > On date Monday 2013-04-01 13:37:23 +0200, Michael Niedermayer encoded:
> > > On Mon, Apr 01, 2013 at 12:23:51PM +0200, Stefano Sabatini wrote:
[...]
> > > > No more comments from me, we can fix it later in case of need as the
> > > > API is marked as experimental, and other minor formatting nits can be
> > > > fixed when it's already in.
> > >
> > > patch applied
> >
> > CC      libavutil/opencl.o
> > libavutil/opencl.c:113:6: error: ‘CL_COMPILE_PROGRAM_FAILURE’ undeclared
> > here (not in a function)
> > libavutil/opencl.c:114:6: error: ‘CL_LINKER_NOT_AVAILABLE’ undeclared here
> > (not in a function)
> > libavutil/opencl.c:115:6: error: ‘CL_LINK_PROGRAM_FAILURE’ undeclared here
> > (not in a function)
> > libavutil/opencl.c:116:6: error: ‘CL_DEVICE_PARTITION_FAILED’ undeclared
> > here (not in a function)
> > libavutil/opencl.c:117:6: error: ‘CL_KERNEL_ARG_INFO_NOT_AVAILABLE’
> > undeclared here (not in a function)
> > libavutil/opencl.c:153:6: error: ‘CL_INVALID_IMAGE_DESCRIPTOR’ undeclared
> > here (not in a function)
> > libavutil/opencl.c:154:6: error: ‘CL_INVALID_COMPILER_OPTIONS’ undeclared
> > here (not in a function)
> > libavutil/opencl.c:155:6: error: ‘CL_INVALID_LINKER_OPTIONS’ undeclared
> > here (not in a function)
> > libavutil/opencl.c:156:6: error: ‘CL_INVALID_DEVICE_PARTITION_COUNT’
> > undeclared here (not in a function)
> >
> > This with the ancient OpenCL 1.0 version shipped with my Debian/Ubuntu.
> >
> > How can we check for the 1.2 version?
> >

> our computer install the opencl patch 1.2 sdk, we download from AMD or
> intel official internet page

We should add a check in configure, so that in case the detected
OpenCL is too old configure will abort with a meaningful message,
which is better than compile-time failure.

So we should check for some symbols which are present in OpenCL 1.2,
but *not* in previous versions of OpenCL.
-- 
FFmpeg = Freak and Fancy Marvellous Portable EnGine