[FFmpeg-devel] [PATCH 1/3] libavutil/opencl: add user spec opencl device APIs 20130408

[Wei Gao]

2013/4/9 Michael Niedermayer <michaelni at gmx.at>

> On Tue, Apr 09, 2013 at 09:55:31AM +0800, Wei Gao wrote:
> > 2013/4/9 Michael Niedermayer <michaelni at gmx.at>
> >
> > > On Mon, Apr 08, 2013 at 02:48:59PM +0800, Wei Gao wrote:
> > > >
> > >
> > > >  opencl.c |  381
> > > +++++++++++++++++++++++++++++++++++----------------------------
> > > >  opencl.h |   67 +++++++++--
> > > >  2 files changed, 275 insertions(+), 173 deletions(-)
> > > > e6174fab6b4906a073e8eb5d075653cc9ff659a7
> > >  0001-add-user-spec-opencl-device-APIs-20130408.patch
> > > > From 6bdb99cfde715bb0b25e7ec92df146757d2d883c Mon Sep 17 00:00:00
> 2001
> > > > From: highgod0401 <highgod0401 at gmail.com>
> > > > Date: Mon, 8 Apr 2013 14:36:58 +0800
> > > > Subject: [PATCH 1/3] add user spec opencl device APIs 20130408
> > > >
> > > > ---
> > > >  libavutil/opencl.c | 381
> > > ++++++++++++++++++++++++++++++-----------------------
> > > >  libavutil/opencl.h |  67 +++++++++-
> > > >  2 files changed, 275 insertions(+), 173 deletions(-)
> > >
> > > [...]
> > >
> > > > diff --git a/libavutil/opencl.h b/libavutil/opencl.h
> > > > index 6ebde10..9679129 100644
> > > > --- a/libavutil/opencl.h
> > > > +++ b/libavutil/opencl.h
> > > > @@ -39,6 +39,32 @@
> > > >
> > > > +
> > > > +/**
> > > >   * Allocate OpenCL external environment.
> > > >   *
> > > >   * It must be freed with av_opencl_free_external_env().
> > > > @@ -87,16 +145,11 @@ int av_opencl_register_kernel_code(const char
> > > *kernel_code);
> > > >   * Initialize the run time OpenCL environment and compile the kernel
> > > >   * code registered with av_opencl_register_kernel_code().
> > > >   *
> > > > - * Currently, the only accepted option is "build_options", used to
> set
> > > > - * options to compile registered kernels code. See reference "OpenCL
> > > > - * Specification Version: 1.2 chapter 5.6.4".
> > > > - *
> > > > - * @param options        dictionary of key/value options
> > > >   * @param ext_opencl_env external OpenCL environment, created by an
> > > >   *                       application program, ignored if set to NULL
> > > >   * @return >=0 on success, a negative error code in case of failure
> > > >   */
> > > > - int av_opencl_init(AVDictionary *options, AVOpenCLExternalEnv
> > > *ext_opencl_env);
> > > > + int av_opencl_init(AVOpenCLExternalEnv *ext_opencl_env);
> > >
> > > for changing recently added API its probably a good idea to also bump
> > > the libavutil minor version number
> > >
> > is there any code to reference, where should I add the minor version
> > number?
>
> see the number to the right of:
> "#define LIBAVUTIL_VERSION_MINOR"
> it should be increased by 1
> so that users of the library could detect that the (not yet stable)
> API has been changed
>
I will add it, thanks

>
>
> >
> > >
> > > [...]
> > >
> > > PS: also you probably want to add yourself to the MAINTAINERS file
> > > though thats seperate from this patch
> > >
> > sorry, where should I add the MAINTAINERS? thanks
>
> theres a MAINTAINERS file in git
> https://github.com/FFmpeg/FFmpeg/blob/master/MAINTAINERS
>
> If you agree to maintain opencl in ffmpeg then you should add yourself
> (with a patch) to this file
>
I will add it, thanks.

>
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Into a blind darkness they enter who follow after the Ignorance,
> they as if into a greater darkness enter who devote themselves
> to the Knowledge alone. -- Isha Upanishad
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
>