[FFmpeg-devel] [PATCH] lavfi/hue: apply major simplifications, and switch to AVOption-based system
Stefano Sabatini
stefasab at gmail.com
Thu Apr 11 21:40:48 CEST 2013
On date Thursday 2013-04-11 21:04:24 +0200, Clément Bœsch encoded:
> [...]
> > From c6e9df87ca91b4d90b1c06f088cbeffd746ca65c Mon Sep 17 00:00:00 2001
> > From: Stefano Sabatini <stefasab at gmail.com>
> > Date: Thu, 11 Apr 2013 01:12:33 +0200
> > Subject: [PATCH] lavfi/hue: apply major simplifications, and switch to
> > AVOption-based system
> >
> > This also drops support for "flat syntax" and "reinit" command.
> >
>
> Fine with me.
>
> > "reinit" command is not very robust and complicates the logic more than
> > necessary, since requires to reset all the options in the command.
> >
>
> This reinit thing should be handled differently anyway. It should be done
> generically by calling again a one or more callbacks.
>
> > *This is a syntax break*.
> > ---
> > doc/filters.texi | 40 +++++----------
> > libavfilter/avfilter.c | 1 -
> > libavfilter/vf_hue.c | 127 +++++++++++++++++-------------------------------
> > 3 files changed, 58 insertions(+), 110 deletions(-)
> >
[...]
> LGTM otherwise.
Fixed, and applied, thanks.
--
FFmpeg = Fierce and Furious Meaningless Patchable Elaborated God
More information about the ffmpeg-devel
mailing list