[FFmpeg-devel] [PATCH 2/2] lavc: check decoded subtitles encoding.

[Clément Bœsch]

On Sun, Apr 21, 2013 at 07:13:39PM +0200, Nicolas George wrote:
> Le duodi 2 floréal, an CCXXI, Clement Boesch a écrit :
> > Not sure about the wording, possibly "The decoded subtitle line doesn't
> > look like UTF-8 so the input character encoding need to be known for
> > correct decoding (see -sub_charenc input option)\n".
> 
> More than two lines of text is too much for an error message, IMHO. The
> error message points to the option name, the documentation for the option
> should be enough to provide all necessary information.
> 

At least fix the parenthesis then. What I don't like in the message you
propose is that it seems to suggest a bad usage of FFmpeg, while it's just
that FFmpeg needs more information. It's not that important, I just feel
it might be too much confusing in its current state.

> > So if you don't have a build with iconv, you just can't decode it (ok,
> > partially) anymore? I would be much more comfortable with a warning...
> 
> People ignore warnings. This is returning invalid data, and possibly
> generating invalid, unusable files. I really think this should be considered
> an error. People just need to install libiconv.
> 

Install, and rebuild FFmpeg possibly, that's not always trivial. Well
anyway, I won't insist on it since you are right about the invalid output
files. Patch is OK.

[...]

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130421/758af5c7/attachment.asc>