[FFmpeg-devel] [PATCH] video stabilization plugins using vid.stab library

Clément Bœsch ubitux at gmail.com
Wed Apr 24 18:48:00 CEST 2013


On Tue, Apr 23, 2013 at 01:22:15AM +0200, Clément Bœsch wrote:
> On Tue, Apr 23, 2013 at 12:33:38AM +0200, Georg Martius wrote:
> > On Friday 19 April 2013 02:04:20 Georg Martius wrote:
> > > On Thursday 18 April 2013 23:33:20 Paul B Mahol wrote:
> > > > > +static av_cold void uninit(AVFilterContext *ctx)
> > > > > +{
> > > > > +    StabData *sd = ctx->priv;
> > > > > +    VSMotionDetect* md = &(sd->md);
> > > > > +
> > > > > +    av_opt_free(sd);
> > > > 
> > > > not needed anymore.
> > > > 
> > > > [...]
> > > 
> > > removed and the other things fixed as well. New and hopefully correct patch
> > > attached.
> > Sorry for the self-reply. I just wanted to remind about the patch (before it 
> > is not applyable again ;-)) 
> > 
> 
> Unless someone has an objection I will apply this (possibly with local
> cosmetics) in the next 48h after another checking of the code.
> 

Applied.

Note that I took the liberty to do some various cosmetics changes in the
following commits.

Also, I fixed and simplified the direct path for vidstabdetect.

BTW, this may be unrelated to this patch, but there is possibly a ref
counting issue somewhere; I have an undefined behaviour reproducible with
vidstabtransform and ffplay (sometimes it has no effect). Input frame
being read-only or no doesn't seem to change anything (output being
changed is still somehow random whatever the input frame state). There is
possibly a problem in the library (I'm using Git version), or maybe in
FFmpeg codebase.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130424/74c5dcb7/attachment.asc>


More information about the ffmpeg-devel mailing list