[FFmpeg-devel] [Read EXIF metadata 1/5] Refactor TIFF tag related functions to share the code.

Michael Niedermayer michaelni at gmx.at
Fri Aug 2 13:11:08 CEST 2013


On Fri, Aug 02, 2013 at 09:52:17AM +0200, Thilo Borgmann wrote:
> Am 02.08.13 03:08, schrieb Michael Niedermayer:
> > On Tue, Jul 30, 2013 at 08:32:40PM +0200, Thilo Borgmann wrote:
> >> ---
> >>  libavcodec/tiff.c |  134 +++++++++++++++++++++++++++++------------------------
> >>  libavcodec/tiff.h |   15 ++++++
> >>  2 files changed, 89 insertions(+), 60 deletions(-)
> >>[...]
> > it appears that this patch is mangled somehow
> > git says
> > fatal: corrupt patch at line 24
> 
> Resending patches 2/5 and 5/5. "git am" now works for me for all patches.

1/5 needs an update too
also lib internal non static functions need an ff_ prefix

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130802/d2a90d69/attachment.asc>


More information about the ffmpeg-devel mailing list