[FFmpeg-devel] should ff_rtp_codec_id() be case insensitive?

[Michael Niedermayer]

On Tue, Aug 06, 2013 at 09:51:14AM +0800, Peng wrote:
> Hi, Michael and Wei-Cheng.
> 
> According to RFC4566, we have the following:
> 
> An SDP session description consists of a number of lines of text of
> the form:
> <type>=<value>
> where <type> MUST be exactly one case-significant character and
> <value> is structured text whose format depends on <type>. In
> general, <value> is either a number of fields delimited by a single
> space character or a free format string, and is *case-significant*
> unless a specific field defines otherwise. Whitespace MUST NOT be
> used on either side of the "=" sign.
> 
> Since the definition of rtpmap attribute mentions no
> case-sensivitity, I guess
> we should assume it to be case-significant.

fully agree

but do you see a problem with the implementation ?
if theres no case sensitive match we after the patch pick also
case insensitive matches.
Are there any cases where this can be worse than picking no match ?

The table does not have any entries that differ by case sensivitity
from each other

Also we could search for case sensitive matches first and print a
warning if none are found but then still accept insensitive matches
That would do the same as the patch but warn about the inconsistency

Thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130806/bf639c46/attachment.asc>