[FFmpeg-devel] [PATCH 4/4] libavcodec: silence bogus ffmpeg/ffplay specific error message

[Nicolas George]

Le primidi 21 thermidor, an CCXXI, wm4 a écrit :
> This error message suggests using the -sub_charenc command line option,
> which is highly specific to the ffmpeg and ffplay utilities. This makes
> the message entirely useless and actively misleading for applications.
> (Users would try passing -sub_charenc directly to the application, which
> would not work.)

The only thing wrong here is the dash, which is ffmpeg-specific.
"sub_charenc" is the name of the codec option all right.

> Also, this message would cause the application to spam the user with
> this message. Typically, an application would try to convert each
> subtitle event, which leads in one error message per line. This is not
> very useful behavior.
> 
> Applications should instead check the error code returned by the decoder
> to detect this case.

This would probably be acceptable if a specific error code was returned,
indeed.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130808/d6c1dae3/attachment.asc>