[FFmpeg-devel] [PATCH] lavf/tee: add support for bitstream filtering

Stefano Sabatini stefasab at gmail.com
Thu Aug 8 12:21:51 CEST 2013


On date Wednesday 2013-08-07 19:39:16 +0200, Nicolas George encoded:
> L'octidi 18 thermidor, an CCXXI, Stefano Sabatini a écrit :
> > Elaborating more on this. I'd need to store the couples
> > specifiers+filters in a dictionary (this destroys the specification
> > order and is a bit more complicate to implement). I leave the design
> > choice to the maintainer.
> 
> Sorry for the delay, I was assuming you wanted to rework the patch first.
> 
> To answer that point, I do not see why you would need to store anything in a
> dictionary. I believe it can be done with something like that:
> 
>     while (entry = av_opt_get(options, "bsfs", IGNORE_SUFFIX)) {
> 	spec = entry->name + strlen("bsfs");
> 	for (i = 0; i < nb_streams; i++) {
> 	    if (stream matches stream specifier) {
> 		if (stream[i]->bsfs) {
> 		    av_log(WARNING, "Duplicate bsfs specification\n");
> 		    continue;
> 		}
> 		parse_bsfs(stream[i], entry->value);
> 	    }
> 	    entry->value = NULL;
> 	    av_opt_set(entry->name, NULL);
> 	}
>     }
> 
> Now that I think on it, I see the added benefit of matching the syntax of
> ffmpeg itself for specifying bitstream filters:
> 
> ffmpeg ... -bsfs:a mp3_header_compress,noise -bsfs:v noise,mjpeg2jpeg ...

Check updated patch.
-- 
FFmpeg = Free Fierce Magical Political Ecstatic Gadget
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavf-tee-add-support-for-bitstream-filtering.patch
Type: text/x-diff
Size: 12869 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130808/65c6a7e2/attachment.bin>


More information about the ffmpeg-devel mailing list