[FFmpeg-devel] [PATCH] lavc: make invalid UTF-8 in subtitle output a non-fatal error

[Nicolas George]

Le primidi 21 thermidor, an CCXXI, Reimar Döffinger a écrit :
> Why not just implement a relatively simple solution like
> supporting a special charenc "noconv" that just passes
> things through (possibly broken) as they are, plus
> some documentation update that says in this case we
> make no promise the output is UTF-8?
> I don't think it's a big deal, when the user requests
> broken data it's ok if he gets it.

With these caveats, it is certainly acceptable.

But I still do not like it, because I can not help but think people who want
that option are using the API incorrectly. Supporting invalid uses now may
be a burden later.

> Btw. as to installing iconv: My experience with trying to
> cross-compile is that libiconv is one of those utterly
> broken libraries that are just impossible to get to cross-compile.

I did not think of cross-compilation. That is a problem indeed.

Then I suspect the best course of action is to provide in lavu a simple API
on top of either iconv/libiconv or a native recoding implementation
supporting only the really easy and necessary encodings (UTF-8, ISO-8859-1
and UTF-16). And possibly add later support for other libraries than iconv,
if they exist.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130809/9dad9245/attachment.asc>