[FFmpeg-devel] [PATCH 3/3] avcodec/utils: avcodec_string: print colorspace type

Michael Niedermayer michaelni at gmx.at
Wed Aug 28 01:02:37 CEST 2013


On Tue, Aug 27, 2013 at 11:25:00PM +0200, Nicolas George wrote:
> Le decadi 10 fructidor, an CCXXI, Michael Niedermayer a écrit :
> > +            if (enc->colorspace<9U) {
> 
> Maybe define the array in a more global scope and use FF_ARRAY_ELEMS?

there probably should be a function that returns a string describing
each
ill factor that out after this patchset is applied


> 
> > +                static const char *name[] =  {
> > +                    "GBR\0",
> > +                    "bt709\0",
> 
> I may be missing something obvious, but why all the \0?

its less the \0 than the lack of , between some, thats concerning me
both fixed

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130828/f457d71b/attachment.asc>


More information about the ffmpeg-devel mailing list