[FFmpeg-devel] [PATCH] avformat/oggparseopus: Check opus_duration() return value

[Michael Niedermayer]

On Thu, Dec 12, 2013 at 03:44:10AM -0300, James Almer wrote:
> On 12/12/13 3:34 AM, James Almer wrote:
> > Regression since 39d11d599cd292485fe991cd22e10d7a1738b3bc
> > 
> > os->pduration would be wrongly assigned a negative value on invalid packets
> > instead of aborting.
> > 
> > Signed-off-by: James Almer <jamrial at gmail.com>
> > ---
> >  libavformat/oggparseopus.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> 

applied (without the typo)



> This makes it behave the same as it was before 39d11d5, but i noticed the one 
> commit after it added a code path that instead adds the AV_PKT_FLAG_CORRUPT to 
> the packet and returns 0 rather than AVERROR_INVALIDDATA.
> 
> Not sure if that should also be done here, but it would be consistent with how 
> vorbis is handled if so.

iam fine with either


> 
> Regards.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 3
"Rare item" - "Common item with rare defect or maybe just a lie"
"Professional" - "'Toy' made in china, not functional except as doorstop"
"Experts will know" - "The seller hopes you are not an expert"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131212/9df20e5b/attachment.asc>