[FFmpeg-devel] [PATCH] ffprobe: output best_effort_timestamp

[Stefano Sabatini]

On date Thursday 2013-11-28 13:10:37 +0100, Stefano Sabatini encoded:
> On date Thursday 2013-11-28 12:01:42 +0100, wm4 encoded:
> > On Thu, 28 Nov 2013 11:28:01 +0100
> > Clément Bœsch <u at pkh.me> wrote:
> > 
> > > On Thu, Nov 28, 2013 at 11:25:41AM +0100, wm4 wrote:
> > > > This is useful for debugging.
> > > > ---
> > > >  ffprobe.c | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git a/ffprobe.c b/ffprobe.c
> > > > index d124d4e..e192e4e 100644
> > > > --- a/ffprobe.c
> > > > +++ b/ffprobe.c
> > > > @@ -1718,6 +1718,8 @@ static void show_frame(WriterContext *w, AVFrame *frame, AVStream *stream,
> > > >      print_time("pkt_pts_time",          frame->pkt_pts, &stream->time_base);
> > > >      print_ts  ("pkt_dts",               frame->pkt_dts);
> > > >      print_time("pkt_dts_time",          frame->pkt_dts, &stream->time_base);
> > > > +    print_ts  ("best_effort_timestamp", frame->best_effort_timestamp);
> > > > +    print_time("best_effort_timestamp_time", frame->best_effort_timestamp, &stream->time_base);
> > > 
> > > Please use the getter for ABI compat.
> > > 
> > 
> > Now with more bullshit compatibility.
> 
> > From edfc769b59f73d1ca536656c7787b1ab1eb72631 Mon Sep 17 00:00:00 2001
> > From: wm4 <nfxjfg at googlemail.com>
> > Date: Thu, 28 Nov 2013 11:24:34 +0100
> > Subject: [PATCH] ffprobe: output best_effort_timestamp
> > 
> > This is useful for debugging.
> > ---
> >  ffprobe.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/ffprobe.c b/ffprobe.c
> > index d124d4e..a4df885 100644
> > --- a/ffprobe.c
> > +++ b/ffprobe.c
> > @@ -1718,6 +1718,8 @@ static void show_frame(WriterContext *w, AVFrame *frame, AVStream *stream,
> >      print_time("pkt_pts_time",          frame->pkt_pts, &stream->time_base);
> >      print_ts  ("pkt_dts",               frame->pkt_dts);
> >      print_time("pkt_dts_time",          frame->pkt_dts, &stream->time_base);
> > +    print_ts  ("best_effort_timestamp", av_frame_get_best_effort_timestamp(frame));
> > +    print_time("best_effort_timestamp_time", av_frame_get_best_effort_timestamp(frame), &stream->time_base);
> >      print_duration_ts  ("pkt_duration",      av_frame_get_pkt_duration(frame));
> >      print_duration_time("pkt_duration_time", av_frame_get_pkt_duration(frame), &stream->time_base);
> >      if (av_frame_get_pkt_pos (frame) != -1) print_fmt    ("pkt_pos", "%"PRId64, av_frame_get_pkt_pos(frame));
> 
> Missing ffprobe.xsd updates (you test with xmllint --schema
> ffprobe.xml).
> 
> Also it probably needs some fate reference updates.

Fixed and pushed.
-- 
FFmpeg = Frightening and Funny Meaningless Problematic Ermetic Gymnast