[FFmpeg-devel] [PATCH] libavcodec: Implementation of AC3 fixed point decoder

[Michael Niedermayer]

On Mon, Dec 30, 2013 at 02:13:20PM +0000, Nedeljko Babic wrote:
> >note, ive fixed some issues and split this patch up, please see
> >the seperate thread about that
> >
> 
> Thanks Michael!
> 
[...9
> >> +     *             constraints: multiple of 4
> >> +     */
> >> +    void (*vector_fmul_window_fixed)(int32_t *dst, const int32_t *src0, const int32_t *src1, const int32_t *win, int len);
> >> +
> >> +} AVFixedDSPContext;
> >> +
> >> +/**
> >> + * Initialize a fixed DSP context.
> >> + *
> >> + * @param fdsp    fixed DSP context
> >> + * @param strict  setting to non-zero avoids using functions which may not be IEEE-754 compliant
> >> + */
> >> +void avpriv_fixed_dsp_init(AVFixedDSPContext *fdsp, int strict);
> >
> >This API/ABI is not extendible, any field added to the struct requires
> >a major version and soname bump, adding such API/ABI is not ok
> >yes i know you copied that design from existing code, its not ok there
> >either
> 
> We can make these functions stand alone and call them as such, but I guess
> that this is bad idea also. Do you have a suggestion how should we treat them
> correctly?

i guess the easiest solution is to make the struct allocated
by something

like for example:
AVFixedDSPContext * avpriv_alloc_fixed_dsp(int strict);
and drop avpriv_fixed_dsp_init()

and document how it has to be freed (like av_free or a seperate
avpriv_free_fixed_dsp()

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20131230/a8c39e6c/attachment.asc>