[FFmpeg-devel] BUG in use of extradata and extradata_size with dvb subtitles and teletext

Carl Eugen Hoyos cehoyos at ag.or.at
Mon Dec 30 18:59:05 CET 2013


Andriy Lysnevych <andriy.lysnevych <at> gmail.com> writes:

> -        case 0x20: /* DVB subtitles...

> +                    case 0x20: /* DVB subtitles...

Imo, this is a good example for a block that you should not 
reindent in the same patch to make reviewing easier.

And the indentation is wrong afaict, it should be:
    case 0x59:
    {
        char type_list[252];
...
        switch(type) {
        case 0x20:

...

> -            }
> +            }          

Neither tabs nor trailing whitespace can be committed to 
the FFmpeg git repository, please use tools/patcheck to 
locate (and remove it).

Thank you for working on this, Carl Eugen



More information about the ffmpeg-devel mailing list